Increase copypastafication of `cargo search` by casey · Pull Request #3684 · rust-lang/cargo

casey · 2017-02-11T02:56:47Z

Formats the search results printed by cargo search so that they can be
copied directly into a Cargo.toml file.

I used ^, since I like being explicit, although that seems not to be the convention, so I'd be happy to remote it.

I also added a # in front of the description, so that that can be copy pastaed as well. I'm not super attached to this idea, but I think it's interesting, since it would serve to document what the various dependencies of a crate are for new contributors.

For example:

$ cargo search clap
clap = "^2.20.3"               # A simple to use, efficient, and full featured  Command Line ArgumentParser
please-clap = "^0.1.0"         # Pattern-match against Clap subcommands and arguments.
clapcomp = "^0.1.5"            # clap completion generator as command
clap-test = "^0.1.1"           # functions and macros to assist in testing clap
structopt = "^0.0.2"           # Parse command line argument by defining a struct.
capgun = "^0.1.1"              # fire when ready file watcher
structopt-derive = "^0.0.2"    # Parse command line argument by defining a struct, derive crate.
cargo-outdated = "^0.3.0"      # Cargo subcommand for displaying when dependencies are out of date
wesers = "^0.4.1"              # a simple HTTP/HTTPS server in Rust
cargo-arch = "^0.1.0"          # Rust Arch Linux package packer
... and 6 crates more (use --limit N to see more)

Formats the search results printed by `cargo search` so that they can be copied directly into a `Cargo.toml` file.

rust-highfive · 2017-02-11T02:57:00Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

alexcrichton · 2017-02-11T17:03:34Z

Nice! Perhaps the ^ could be left out though since it's the default?

casey · 2017-02-11T21:57:27Z

Removed the ^.

alexcrichton · 2017-02-12T01:10:33Z

@bors: r+

bors · 2017-02-12T01:10:35Z

📌 Commit 94aa4ae has been approved by alexcrichton

bors · 2017-02-12T01:10:41Z

⌛ Testing commit 94aa4ae with merge f4f264c...

bors · 2017-02-12T02:32:02Z

💔 Test failed - status-appveyor

casey · 2017-02-12T02:58:31Z

Looks like an unrelated failure. It failed to remove a directory:

     Running target\x86_64-pc-windows-msvc\release\deps\required_features-6778747566db0498.exe
running 15 tests
.F.............
failures:
---- bench_default_features stdout ----
	running `C:\projects\cargo\target\x86_64-pc-windows-msvc\release\cargo bench`
running `C:\projects\cargo\target\x86_64-pc-windows-msvc\release\cargo bench --no-default-features`
running `C:\projects\cargo\target\x86_64-pc-windows-msvc\release\cargo bench --bench=foo`
thread 'bench_default_features' panicked at 'failed to remove dir C:\projects\cargo\target\x86_64-pc-windows-msvc\cit\t0\foo\target\release\deps: The directory is not empty. (os error 145)', tests\cargotest\support\paths.rs:159
note: Run with `RUST_BACKTRACE=1` for a backtrace.
failures:
    bench_default_features
test result: FAILED. 14 passed; 1 failed; 0 ignored; 0 measured
error: test failed
Makefile:128: recipe for target 'test-unit-x86_64-pc-windows-ms

alexcrichton · 2017-02-12T05:23:06Z

@bors: retry

…

On Sat, Feb 11, 2017 at 8:58 PM, Casey Rodarmor ***@***.***> wrote: Looks like an unrelated failure. It failed to remove a directory: running 15 tests .F............. failures: ---- bench_default_features stdout ---- running `C:\projects\cargo\target\x86_64-pc-windows-msvc\release\cargo bench` running `C:\projects\cargo\target\x86_64-pc-windows-msvc\release\cargo bench --no-default-features` running `C:\projects\cargo\target\x86_64-pc-windows-msvc\release\cargo bench --bench=foo` thread 'bench_default_features' panicked at 'failed to remove dir C:\projects\cargo\target\x86_64-pc-windows-msvc\cit\t0\foo\target\release\deps: The directory is not empty. (os error 145)', tests\cargotest\support\paths.rs:159 note: Run with `RUST_BACKTRACE=1` for a backtrace. failures: bench_default_features test result: FAILED. 14 passed; 1 failed; 0 ignored; 0 measured error: test failed Makefile:128: recipe for target 'test-unit-x86_64-pc-windows-ms — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3684 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95NOxEDqWJ31IWyc6zzCnt1C08zSLks5rbnVXgaJpZM4L-DZu> .

bors · 2017-02-12T05:23:12Z

⌛ Testing commit 94aa4ae with merge 4662d86...

bors · 2017-02-12T06:05:05Z

💔 Test failed - status-appveyor

alexcrichton · 2017-02-12T17:16:11Z

@bors: retry

…

On Sun, Feb 12, 2017 at 12:05 AM, bors ***@***.***> wrote: 💔 Test failed - status-appveyor <https://ci.appveyor.com/project/rust-lang-libs/cargo/build/1.0.1168> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3684 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95IL6cSpeDbB_iU87Vhak1UtNyRxiks5rbqESgaJpZM4L-DZu> .

bors · 2017-02-12T18:18:13Z

⌛ Testing commit 94aa4ae with merge d26ae4d...

Increase copypastafication of `cargo search` Formats the search results printed by `cargo search` so that they can be copied directly into a `Cargo.toml` file. I used `^`, since I like being explicit, although that seems not to be the convention, so I'd be happy to remote it. I also added a `#` in front of the description, so that that can be copy pastaed as well. I'm not super attached to this idea, but I think it's interesting, since it would serve to document what the various dependencies of a crate are for new contributors. For example: ``` $ cargo search clap clap = "^2.20.3" # A simple to use, efficient, and full featured Command Line ArgumentParser please-clap = "^0.1.0" # Pattern-match against Clap subcommands and arguments. clapcomp = "^0.1.5" # clap completion generator as command clap-test = "^0.1.1" # functions and macros to assist in testing clap structopt = "^0.0.2" # Parse command line argument by defining a struct. capgun = "^0.1.1" # fire when ready file watcher structopt-derive = "^0.0.2" # Parse command line argument by defining a struct, derive crate. cargo-outdated = "^0.3.0" # Cargo subcommand for displaying when dependencies are out of date wesers = "^0.4.1" # a simple HTTP/HTTPS server in Rust cargo-arch = "^0.1.0" # Rust Arch Linux package packer ... and 6 crates more (use --limit N to see more) ```

bors · 2017-02-12T19:20:04Z

💔 Test failed - status-appveyor

alexcrichton · 2017-02-13T15:03:09Z

@bors: retry

…

On Sun, Feb 12, 2017 at 1:20 PM, bors ***@***.***> wrote: 💔 Test failed - status-appveyor <https://ci.appveyor.com/project/rust-lang-libs/cargo/build/1.0.1169> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3684 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95NkXXLmlt62dcEq903ozoMINbQZ1ks5rb1tlgaJpZM4L-DZu> .

bors · 2017-02-13T15:42:12Z

⌛ Testing commit 94aa4ae with merge 4a19374...

bors · 2017-02-13T17:16:13Z

💔 Test failed - status-appveyor

alexcrichton · 2017-02-13T18:01:21Z

@bors: retry

…

On Mon, Feb 13, 2017 at 11:16 AM, bors ***@***.***> wrote: 💔 Test failed - status-appveyor <https://ci.appveyor.com/project/rust-lang-libs/cargo/build/1.0.1172> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3684 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95JLy45_FkZVl6uDWfPMZ7rbSsYkFks5rcI_dgaJpZM4L-DZu> .

bors · 2017-02-13T21:05:51Z

⌛ Testing commit 94aa4ae with merge 76b32ab...

Increase copypastafication of `cargo search` Formats the search results printed by `cargo search` so that they can be copied directly into a `Cargo.toml` file. I used `^`, since I like being explicit, although that seems not to be the convention, so I'd be happy to remote it. I also added a `#` in front of the description, so that that can be copy pastaed as well. I'm not super attached to this idea, but I think it's interesting, since it would serve to document what the various dependencies of a crate are for new contributors. For example: ``` $ cargo search clap clap = "^2.20.3" # A simple to use, efficient, and full featured Command Line ArgumentParser please-clap = "^0.1.0" # Pattern-match against Clap subcommands and arguments. clapcomp = "^0.1.5" # clap completion generator as command clap-test = "^0.1.1" # functions and macros to assist in testing clap structopt = "^0.0.2" # Parse command line argument by defining a struct. capgun = "^0.1.1" # fire when ready file watcher structopt-derive = "^0.0.2" # Parse command line argument by defining a struct, derive crate. cargo-outdated = "^0.3.0" # Cargo subcommand for displaying when dependencies are out of date wesers = "^0.4.1" # a simple HTTP/HTTPS server in Rust cargo-arch = "^0.1.0" # Rust Arch Linux package packer ... and 6 crates more (use --limit N to see more) ```

bors · 2017-02-13T23:23:37Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 76b32ab to master...

Increase copypastafication of cargo search

8af9e95

Formats the search results printed by `cargo search` so that they can be copied directly into a `Cargo.toml` file.

rust-highfive assigned brson Feb 11, 2017

Leave off ^, since it's the default.

94aa4ae

bors merged commit 94aa4ae into rust-lang:master Feb 13, 2017

ehuss added this to the 1.17.0 milestone Feb 6, 2022

Conversation

casey commented Feb 11, 2017

Uh oh!

rust-highfive commented Feb 11, 2017

Uh oh!

alexcrichton commented Feb 11, 2017

Uh oh!

casey commented Feb 11, 2017

Uh oh!

alexcrichton commented Feb 12, 2017

Uh oh!

bors commented Feb 12, 2017

Uh oh!

bors commented Feb 12, 2017

Uh oh!

bors commented Feb 12, 2017

Uh oh!

casey commented Feb 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexcrichton commented Feb 12, 2017 via email

Uh oh!

bors commented Feb 12, 2017

Uh oh!

bors commented Feb 12, 2017

Uh oh!

alexcrichton commented Feb 12, 2017 via email

Uh oh!

bors commented Feb 12, 2017

Uh oh!

bors commented Feb 12, 2017

Uh oh!

alexcrichton commented Feb 13, 2017 via email

Uh oh!

bors commented Feb 13, 2017

Uh oh!

bors commented Feb 13, 2017

Uh oh!

alexcrichton commented Feb 13, 2017 via email

Uh oh!

bors commented Feb 13, 2017

Uh oh!

bors commented Feb 13, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

casey commented Feb 12, 2017 •

edited

Loading